refactor: code review improvements #41

shahondin1624 · 2026-03-12T13:48:31+01:00

shahondin1624 commented

2026-03-12 13:48:31 +01:00

Summary

Bug fixes: SvelteMap reactivity in sessions store, theme listener memory leak, transport singleton caching, form/button type mismatch, safer retry validation
Shared utilities: date formatting, session config check, result source config, sample data module
Shared components: <Backdrop> and <PageHeader> replacing duplicated markup across 5+ files
Orchestration composable: extracted streaming/error/audit/memory logic from chat page (310→85 lines of script)
AuditTimeline: consolidated 3 switch functions into single config record
LineageTree: dark mode SVG colors, memoized leaf count computation
README: added usage guide and project structure

Net: +753 / -579 lines across 26 files (7 new, 19 modified)

Test plan

npm run check — 0 errors, 0 warnings
npm run lint — clean
npm run build — production build succeeds
Manual: navigate all pages, toggle themes, open/close sidebars, send chat message, verify retry

🤖 Generated with Claude Code

## Summary - **Bug fixes**: SvelteMap reactivity in sessions store, theme listener memory leak, transport singleton caching, form/button type mismatch, safer retry validation - **Shared utilities**: date formatting, session config check, result source config, sample data module - **Shared components**: `<Backdrop>` and `<PageHeader>` replacing duplicated markup across 5+ files - **Orchestration composable**: extracted streaming/error/audit/memory logic from chat page (310→85 lines of script) - **AuditTimeline**: consolidated 3 switch functions into single config record - **LineageTree**: dark mode SVG colors, memoized leaf count computation - **README**: added usage guide and project structure Net: +753 / -579 lines across 26 files (7 new, 19 modified) ## Test plan - [x] `npm run check` — 0 errors, 0 warnings - [x] `npm run lint` — clean - [x] `npm run build` — production build succeeds - [ ] Manual: navigate all pages, toggle themes, open/close sidebars, send chat message, verify retry 🤖 Generated with [Claude Code](https://claude.com/claude-code)

shahondin1624 added 1 commit 2026-03-12 13:48:32 +01:00

refactor: code review improvements — fix bugs, extract shared utilities, add README 38f5f31b92

- Fix reactivity bug: use SvelteMap instead of Map in sessions store
- Fix theme listener memory leak: guard against double-init, return cleanup function
- Fix transport singleton ignoring different endpoints
- Fix form/button type mismatch in MessageInput
- Add safer retry validation in chat page
- Extract shared utilities: date formatting, session config check, result source config
- Extract shared components: Backdrop, PageHeader
- Extract orchestration composable from chat page (310→85 lines of script)
- Consolidate AuditTimeline switch functions into config record
- Move sample data to dedicated module
- Add dark mode support for LineageTree SVG colors
- Memoize leaf count computation in LineageTree
- Update README with usage guide and project structure

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

shahondin1624 merged commit d7d1d9fd57 into main

2026-03-12 13:48:57 +01:00

shahondin1624 deleted branch refactor/code-review-improvements

2026-03-12 13:48:57 +01:00

shahondin1624 referenced this issue from a commit

2026-03-12 13:48:58 +01:00

Merge pull request 'refactor: code review improvements' (#41) from refactor/code-review-improvements into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: llm-multiverse/llm-multiverse-ui#41