feat: implement extraction step (#31) #119

shahondin1624 · 2026-03-09T23:08:09+01:00

shahondin1624 commented

2026-03-09 23:08:09 +01:00

Summary

Implements post-retrieval extraction step for the Memory Service's QueryMemory pipeline. After the 4-stage retrieval returns candidates, an LLM call via Model Gateway's Inference RPC extracts the most relevant segment from each candidate's corpus.

Key changes

Proto changes: Added skip_extraction field to QueryMemoryRequest and extraction_confidence field to QueryMemoryResponse
New extraction/ module: ExtractionClient wrapping Model Gateway Inference RPC, prompt builder/parser in prompt.rs
ExtractionConfig in config.rs with enabled, max_tokens, temperature fields
Service integration: query_memory handler runs extraction on pipeline results unless disabled by config or per-request toggle
Graceful degradation: If extraction fails for a candidate, falls back to truncated corpus

Quality gates

Build: PASS
Clippy: PASS (zero warnings)
Tests: PASS (169 tests, 0 failures)
Coverage: PASS (>95% on all new/modified files)

Files

Created: extraction/mod.rs, extraction/prompt.rs, issue-031.md
Modified: memory.proto, config.rs, service.rs, main.rs, lib.rs, _index.md

Closes #31 | Plan: implementation-plans/issue-031.md

## Summary Implements post-retrieval extraction step for the Memory Service's `QueryMemory` pipeline. After the 4-stage retrieval returns candidates, an LLM call via Model Gateway's `Inference` RPC extracts the most relevant segment from each candidate's corpus. ### Key changes - **Proto changes:** Added `skip_extraction` field to `QueryMemoryRequest` and `extraction_confidence` field to `QueryMemoryResponse` - **New `extraction/` module:** `ExtractionClient` wrapping Model Gateway `Inference` RPC, prompt builder/parser in `prompt.rs` - **`ExtractionConfig`** in `config.rs` with `enabled`, `max_tokens`, `temperature` fields - **Service integration:** `query_memory` handler runs extraction on pipeline results unless disabled by config or per-request toggle - **Graceful degradation:** If extraction fails for a candidate, falls back to truncated corpus ### Quality gates - Build: PASS - Clippy: PASS (zero warnings) - Tests: PASS (169 tests, 0 failures) - Coverage: PASS (>95% on all new/modified files) ### Files - **Created:** `extraction/mod.rs`, `extraction/prompt.rs`, `issue-031.md` - **Modified:** `memory.proto`, `config.rs`, `service.rs`, `main.rs`, `lib.rs`, `_index.md` Closes #31 | Plan: `implementation-plans/issue-031.md`

shahondin1624 added 9 commits 2026-03-09 23:08:09 +01:00

feat: extraction step (#31 ): issue-031.md 295e9bddd8

feat: extraction step (#31 ): mod.rs 7f1a0aad3a

feat: extraction step (#31 ): prompt.rs 947e65f0bb

feat: extraction step (#31 ): _index.md a074b2686b

feat: extraction step (#31 ): memory.proto 20e1bba174

feat: extraction step (#31 ): config.rs 41211d20a2

feat: extraction step (#31 ): lib.rs 52c0cba16d

feat: extraction step (#31 ): main.rs b6fdf531f8

feat: extraction step (#31 ): service.rs 8471c5b19f

shahondin1624 referenced this pull request

2026-03-09 23:08:17 +01:00