Refactor: extract shared service infrastructure (config, startup, shutdown) #123

New Issue

shahondin1624 · 2026-03-09T23:48:41+01:00

shahondin1624 commented

2026-03-09 23:48:41 +01:00

Problem

All three implemented Rust services (audit, secrets, memory) duplicate the same structural patterns:

Config loading — Each service has an identical Config::load() method:

pub fn load(path: Option<&str>) -> anyhow::Result<Self> {
    match path {
        Some(p) => { let contents = std::fs::read_to_string(p)?; let config: Config = toml::from_str(&contents)?; Ok(config) }
        None => Ok(Self::default()),
    }
}

Files: services/audit/src/config.rs:54-63, services/secrets/src/config.rs:51-59, services/memory/src/config.rs:184-193

listen_addr() method — Identical format!("{}:{}", self.host, self.port) in all three configs.
shutdown_signal() function — Identical async function in all three main.rs files.
Tracing initialization — Same tracing_subscriber::fmt().with_env_filter(...) boilerplate in all three main.rs files.
Config environment variable pattern — Same std::env::var("SERVICE_CONFIG").ok() pattern.

Where

services/audit/src/config.rs, services/audit/src/main.rs
services/secrets/src/config.rs, services/secrets/src/main.rs
services/memory/src/config.rs, services/memory/src/main.rs

Impact

As more services are added (Model Gateway, Tool Broker), this duplication will grow. Bug fixes or improvements (e.g., adding SIGHUP reload, config validation, graceful drain) would need to be applied in every service.

Suggested approach

Create a services/common workspace crate (e.g., llm-multiverse-common) containing:

A ServiceConfig trait with load() and listen_addr() default implementations
A shutdown_signal() utility function
A init_tracing(service_name: &str) helper
Optionally a serve() helper that combines Server::builder + shutdown signal

Each service would depend on this crate and delegate to it, keeping service-specific config fields in their own structs.

🤖 Generated by refactor-review agent

## Problem All three implemented Rust services (audit, secrets, memory) duplicate the same structural patterns: 1. **Config loading** — Each service has an identical `Config::load()` method: ```rust pub fn load(path: Option<&str>) -> anyhow::Result<Self> { match path { Some(p) => { let contents = std::fs::read_to_string(p)?; let config: Config = toml::from_str(&contents)?; Ok(config) } None => Ok(Self::default()), } } ``` Files: `services/audit/src/config.rs:54-63`, `services/secrets/src/config.rs:51-59`, `services/memory/src/config.rs:184-193` 2. **`listen_addr()` method** — Identical `format!("{}:{}", self.host, self.port)` in all three configs. 3. **`shutdown_signal()` function** — Identical async function in all three `main.rs` files. 4. **Tracing initialization** — Same `tracing_subscriber::fmt().with_env_filter(...)` boilerplate in all three `main.rs` files. 5. **Config environment variable pattern** — Same `std::env::var("SERVICE_CONFIG").ok()` pattern. ## Where - `services/audit/src/config.rs`, `services/audit/src/main.rs` - `services/secrets/src/config.rs`, `services/secrets/src/main.rs` - `services/memory/src/config.rs`, `services/memory/src/main.rs` ## Impact As more services are added (Model Gateway, Tool Broker), this duplication will grow. Bug fixes or improvements (e.g., adding SIGHUP reload, config validation, graceful drain) would need to be applied in every service. ## Suggested approach Create a `services/common` workspace crate (e.g., `llm-multiverse-common`) containing: - A `ServiceConfig` trait with `load()` and `listen_addr()` default implementations - A `shutdown_signal()` utility function - A `init_tracing(service_name: &str)` helper - Optionally a `serve()` helper that combines Server::builder + shutdown signal Each service would depend on this crate and delegate to it, keeping service-specific config fields in their own structs. 🤖 Generated by refactor-review agent

shahondin1624 commented

2026-03-11 11:56:58 +01:00

3rd review update: This issue now affects 5 Rust services (up from 3 when filed):

Pattern	audit	secrets	memory	model-gateway	tool-broker
`Config::load()`	yes	yes	yes	yes	yes
`listen_addr()`	yes	yes	yes	yes	yes
`shutdown_signal()`	yes	yes	yes	yes	yes
tracing init	yes	yes	yes	yes	yes
audit client connect boilerplate	--	yes	yes	yes	yes
`with_audit_client()` builder	--	yes	yes	yes	yes

The audit client wiring pattern (connect-if-configured with warn-on-failure) is now copied identically in 4 service main.rs files. This compounds the case for a shared crate.

Priority should increase given the expanded surface area.

**3rd review update:** This issue now affects 5 Rust services (up from 3 when filed): | Pattern | audit | secrets | memory | model-gateway | tool-broker | |---------|-------|---------|--------|---------------|-------------| | `Config::load()` | yes | yes | yes | yes | yes | | `listen_addr()` | yes | yes | yes | yes | yes | | `shutdown_signal()` | yes | yes | yes | yes | yes | | tracing init | yes | yes | yes | yes | yes | | audit client connect boilerplate | -- | yes | yes | yes | yes | | `with_audit_client()` builder | -- | yes | yes | yes | yes | The audit client wiring pattern (connect-if-configured with warn-on-failure) is now copied identically in 4 service `main.rs` files. This compounds the case for a shared crate. Priority should increase given the expanded surface area.

shahondin1624 referenced this issue

2026-03-11 11:57:04 +01:00

Refactor: deduplicate mock gateway servers and SHA-256 hashing #124

shahondin1624 referenced this issue from a commit

2026-03-11 13:24:55 +01:00

refactor: extract shared Rust service infrastructure into llm-common crate (issue #123)

shahondin1624 referenced this issue

2026-03-11 13:25:10 +01:00

refactor: extract shared Rust service infrastructure (#123) #225

shahondin1624 referenced this issue from a commit

2026-03-11 13:25:16 +01:00

Merge pull request 'refactor: extract shared Rust service infrastructure (#123)' (#225) from refactor/issue-123-shared-service-infra into main

shahondin1624 commented

2026-03-11 13:25:17 +01:00

Implemented in PR #225. Created services/common (llm-common) crate with ServiceConfig trait providing default load() and listen_addr() methods, plus shared shutdown_signal(), init_tracing(), and config_path_from_env() functions. All 5 Rust services now use the shared crate, removing ~100 lines of duplicated boilerplate. Dockerfile template updated to include the new crate.

Implemented in PR #225. Created `services/common` (`llm-common`) crate with `ServiceConfig` trait providing default `load()` and `listen_addr()` methods, plus shared `shutdown_signal()`, `init_tracing()`, and `config_path_from_env()` functions. All 5 Rust services now use the shared crate, removing ~100 lines of duplicated boilerplate. Dockerfile template updated to include the new crate.

shahondin1624 closed this issue

2026-03-11 13:25:21 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: llm-multiverse/llm-multiverse#123