llm-multiverse/llm-multiverse
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve tech debt from issue #29 review (#116) #128

Merged
shahondin1624 merged 1 commits from feature/issue-116-tech-debt-29-review into main 2026-03-10 07:37:04 +01:00
Conversation 0 Commits 1 Files Changed 9 +191 -20
shahondin1624 commented 2026-03-10 07:36:58 +01:00
Owner
Copy Link

Summary\n\n- Add ROLLBACK handling to store_embeddings() to prevent dirty transactional state on failure\n- Add NaN/infinity validation to format_vector_literal() with new DbError::InvalidEmbedding variant\n- Update all callers across retrieval stages and pipeline\n\n### Quality gates\n- Build: PASS\n- Clippy: PASS (zero warnings)\n- Tests: PASS (189+ memory service tests)\n\nCloses #116

## Summary\n\n- Add ROLLBACK handling to store_embeddings() to prevent dirty transactional state on failure\n- Add NaN/infinity validation to format_vector_literal() with new DbError::InvalidEmbedding variant\n- Update all callers across retrieval stages and pipeline\n\n### Quality gates\n- Build: PASS\n- Clippy: PASS (zero warnings)\n- Tests: PASS (189+ memory service tests)\n\nCloses #116
shahondin1624 added 1 commit 2026-03-10 07:36:59 +01:00
fix: resolve tech debt from issue #29 review f723bc9046 
Closes #116

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 1208d4ca28 into main 2026-03-10 07:37:04 +01:00
shahondin1624 deleted branch feature/issue-116-tech-debt-29-review 2026-03-10 07:37:04 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
cat:agent
Agent related
 cat:cross-cutting
Cross-cutting concern
 cat:deployment
Deployment related
 cat:devops
DevOps related
 cat:performance
Performance related
 cat:security
Security related
 cat:tech-debt
Technical debt from code reviews
 lang:protobuf
Protocol Buffers
 lang:python
Python language
 lang:rust
Rust language
 priority:critical
Critical priority
 priority:high
High priority
 priority:low
Low priority
 priority:medium
Medium priority
 service:audit
Audit service
 service:memory
Memory service
 service:model-gateway
Model Gateway service
 service:orchestrator
Orchestrator service
 service:search
Search service
 service:secrets
Secrets service
 service:tool-broker
Tool Broker service
 type:bug
Bug fix
 type:documentation
Docs
 type:feature
New functionality
 type:infrastructure
Build tooling, project setup
 type:refactor
Restructuring
 type:research
Investigation, benchmarking
 type:testing
Tests
 workflow:blocked
Blocked after max retries
 workflow:manual
Requires manual intervention — blocked from auto-dev
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: llm-multiverse/llm-multiverse#128
Delete Branch "feature/issue-116-tech-debt-29-review"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?