shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

No centralized validation layer for Shadowrun 5e domain rules #106

New Issue
Closed
opened 2026-04-04 18:42:33 +02:00 by shahondin1624 · 0 comments
shahondin1624 commented 2026-04-04 18:42:33 +02:00
Owner
Copy Link
Copy Source

Description

Business rules (essence max 6.0, attribute limits per metatype, wound modifier -1 per 3 boxes, etc.) are scattered across UI and model classes. No centralized validator exists, making it possible to create invalid character states by bypassing the UI.

Expected Behavior

  • Centralized validation module that enforces SR5e rules
  • Validation invoked on model changes (not just UI input)
  • Clear error messages for rule violations

Acceptance Criteria

  • Validation module with rules for attributes, essence, damage, etc.
  • Validation runs on character state changes
  • Invalid states produce clear error messages
  • UI uses the same validation as the model layer
  • Unit tests for key validation rules
## Description Business rules (essence max 6.0, attribute limits per metatype, wound modifier -1 per 3 boxes, etc.) are scattered across UI and model classes. No centralized validator exists, making it possible to create invalid character states by bypassing the UI. ## Expected Behavior - Centralized validation module that enforces SR5e rules - Validation invoked on model changes (not just UI input) - Clear error messages for rule violations ## Acceptance Criteria - [ ] Validation module with rules for attributes, essence, damage, etc. - [ ] Validation runs on character state changes - [ ] Invalid states produce clear error messages - [ ] UI uses the same validation as the model layer - [ ] Unit tests for key validation rules
shahondin1624 added the priority:should-havetype:architecture labels 2026-04-04 18:42:33 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label priority:should-have type:architecture
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#106
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?