shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Test coverage gaps: no ViewModel, integration, or modifier system tests #108

New Issue
Closed
opened 2026-04-04 18:42:45 +02:00 by shahondin1624 · 0 comments
shahondin1624 commented 2026-04-04 18:42:45 +02:00
Owner
Copy Link
Copy Source

Description

Current tests cover DamageMonitor, DiceRoll, serialization, and some UI components. Significant gaps exist:

  • No ViewModel tests (auto-save behavior, state management)
  • No integration tests (attribute change → damage recalculation flow)
  • No modifier system tests (cache behavior, modifier accumulation)
  • No UI tests for complex dialogs (CharacterDataEditDialog, ImportCharacterDialog)

Expected Behavior

  • Comprehensive test coverage for critical paths
  • Integration tests for cross-component workflows
  • ViewModel unit tests with mocked dependencies

Acceptance Criteria

  • ViewModel tests for save/load/error paths
  • Integration test: modify attribute → verify damage monitor updates
  • Modifier system tests: cache hits, accumulation, type safety
  • UI tests for edit dialogs with validation
  • Test coverage report available
## Description Current tests cover DamageMonitor, DiceRoll, serialization, and some UI components. Significant gaps exist: - No ViewModel tests (auto-save behavior, state management) - No integration tests (attribute change → damage recalculation flow) - No modifier system tests (cache behavior, modifier accumulation) - No UI tests for complex dialogs (CharacterDataEditDialog, ImportCharacterDialog) ## Expected Behavior - Comprehensive test coverage for critical paths - Integration tests for cross-component workflows - ViewModel unit tests with mocked dependencies ## Acceptance Criteria - [ ] ViewModel tests for save/load/error paths - [ ] Integration test: modify attribute → verify damage monitor updates - [ ] Modifier system tests: cache hits, accumulation, type safety - [ ] UI tests for edit dialogs with validation - [ ] Test coverage report available
shahondin1624 added the epic:testingpriority:should-havetype:architecture labels 2026-04-04 18:42:45 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label epic:testing priority:should-have type:architecture
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?