shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: consolidate essence formatting into single shared function (Closes #80) #122

Merged
shahondin1624 merged 1 commits from feature/issue-80-essence-float-precision-formatting into main 2026-04-04 22:28:55 +02:00
Conversation 0 Commits 1 Files Changed 4
+78 -21
shahondin1624 commented 2026-04-04 22:28:50 +02:00
Owner
Copy Link
Copy Source

Summary

  • Consolidated two separate essence formatting functions (in CharacterDataEditDialog.kt and ResourcePanel.kt) into a single shared formatEssence() function in lib/functions/Formatting.kt
  • The old formatEssenceForEdit() used imprecise + 0.5f rounding that could produce different results than the roundToInt-based approach in ResourcePanel
  • Added comprehensive unit tests for the shared function covering edge cases and floating-point precision

Closes #80

Test plan

  • FormatEssenceTest passes all 10 tests including floating-point precision edge cases
  • Existing tests unaffected (pre-existing ExposedDropdownMenuBox failures are unrelated)
## Summary - Consolidated two separate essence formatting functions (in `CharacterDataEditDialog.kt` and `ResourcePanel.kt`) into a single shared `formatEssence()` function in `lib/functions/Formatting.kt` - The old `formatEssenceForEdit()` used imprecise `+ 0.5f` rounding that could produce different results than the `roundToInt`-based approach in `ResourcePanel` - Added comprehensive unit tests for the shared function covering edge cases and floating-point precision Closes #80 ## Test plan - [x] `FormatEssenceTest` passes all 10 tests including floating-point precision edge cases - [x] Existing tests unaffected (pre-existing ExposedDropdownMenuBox failures are unrelated)
shahondin1624 added 1 commit 2026-04-04 22:28:50 +02:00
fix: consolidate essence formatting into single shared function (Closes #80) a57e612918 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shahondin1624 merged commit ca0e17c89d into main 2026-04-04 22:28:55 +02:00
shahondin1624 deleted branch feature/issue-80-essence-float-precision-formatting 2026-04-04 22:28:56 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#122
Delete Branch "feature/issue-80-essence-float-precision-formatting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?