fix: apply wound modifiers to dice rolls and display in roll dialogs (Closes #82) #124

2026-04-04T22:57:41+02:00

shahondin1624 commented

2026-04-04 22:57:41 +02:00

Summary

Wound modifier penalties from physical damage are now automatically subtracted from dice pools for all roll types (simple, opposed, extended)
The penalty is displayed as "Pool: X, Wound Modifier: -Y, Rolling: Z" in both the roll type selector and result dialogs
Characters with 0 damage see no wound modifier UI

Changes

CharacterSheetPage: Computes wound modifier from character.damageMonitor.woundModifier() and reduces effective pool size before rolling
DiceRollTypeSelector: Shows wound modifier info banner when penalty is active
DiceRollResultDialog: Shows wound modifier breakdown above roll results
OpposedTestResultDialog: Shows wound modifier breakdown above opposed test results
ExtendedTestResultDialog: Shows wound modifier breakdown above extended test results
TestTags: Added DICE_ROLL_WOUND_MODIFIER tag for testability

Closes #82

## Summary - Wound modifier penalties from physical damage are now automatically subtracted from dice pools for all roll types (simple, opposed, extended) - The penalty is displayed as "Pool: X, Wound Modifier: -Y, Rolling: Z" in both the roll type selector and result dialogs - Characters with 0 damage see no wound modifier UI ## Changes - **CharacterSheetPage**: Computes wound modifier from `character.damageMonitor.woundModifier()` and reduces effective pool size before rolling - **DiceRollTypeSelector**: Shows wound modifier info banner when penalty is active - **DiceRollResultDialog**: Shows wound modifier breakdown above roll results - **OpposedTestResultDialog**: Shows wound modifier breakdown above opposed test results - **ExtendedTestResultDialog**: Shows wound modifier breakdown above extended test results - **TestTags**: Added `DICE_ROLL_WOUND_MODIFIER` tag for testability Closes #82

shahondin1624 added 1 commit 2026-04-04 22:57:41 +02:00

fix: apply wound modifiers to dice rolls and display in roll dialogs (Closes #82 ) 3f54038b45

Wound modifier penalties from physical damage are now automatically
subtracted from dice pools for all roll types (simple, opposed, extended).
The penalty is displayed as "Pool: X, Wound Modifier: Y, Rolling: Z"
in both the roll type selector and result dialogs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

shahondin1624 merged commit 431271edce into main

2026-04-04 22:57:45 +02:00

shahondin1624 deleted branch feature/issue-82-wound-modifiers-applied-to-dice-rolls

2026-04-04 22:57:45 +02:00

shahondin1624 referenced this issue from a commit

2026-04-04 22:57:47 +02:00

fix: apply wound modifiers to dice rolls and display in roll dialogs (Closes #82) (#124)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#124