shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: rename Sligth_of_hand typo and resolve TODO attribute mappings (Closes #83) #125

Merged
shahondin1624 merged 1 commits from feature/issue-83-typo-sligth-of-hand-5-incomplete-todo-attribute-ma into main 2026-04-04 23:08:25 +02:00
Conversation 0 Commits 1 Files Changed 1
+9 -8
shahondin1624 commented 2026-04-04 23:08:18 +02:00
Owner
Copy Link
Copy Source

Summary

  • Rename Sligth_of_hand to Sleight_of_hand with @SerialName("Sligth_of_hand") for backward serialization compatibility
  • Add Con(Charisma) as the correct SR5e skill in the alphabetical position where the typo previously sat
  • Fix Demolitions attribute from Intuition to Logic per SR5e rules
  • Add Exotic_Melee_Weapon(Agility), Exotic_Ranged_Weapon(Agility), and Pilot_Exotic_Vehicle(Reaction)
  • Remove all 5 TODO comments now that mappings are complete

Closes #83

## Summary - Rename `Sligth_of_hand` to `Sleight_of_hand` with `@SerialName("Sligth_of_hand")` for backward serialization compatibility - Add `Con(Charisma)` as the correct SR5e skill in the alphabetical position where the typo previously sat - Fix `Demolitions` attribute from `Intuition` to `Logic` per SR5e rules - Add `Exotic_Melee_Weapon(Agility)`, `Exotic_Ranged_Weapon(Agility)`, and `Pilot_Exotic_Vehicle(Reaction)` - Remove all 5 TODO comments now that mappings are complete Closes #83
shahondin1624 added 1 commit 2026-04-04 23:08:18 +02:00
fix: rename Sligth_of_hand typo and resolve TODO attribute mappings (Closes #83) 35fb6abcaf 
- Rename Sligth_of_hand to Sleight_of_hand with @SerialName for backward compatibility
- Add Con(Charisma) as the correct SR5e skill in that alphabetical position
- Fix Demolitions attribute from Intuition to Logic per SR5e rules
- Add Exotic_Melee_Weapon(Agility) and Exotic_Ranged_Weapon(Agility)
- Add Pilot_Exotic_Vehicle(Reaction)
- Remove all 5 TODO comments now that mappings are complete

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shahondin1624 merged commit a950589041 into main 2026-04-04 23:08:25 +02:00
shahondin1624 deleted branch feature/issue-83-typo-sligth-of-hand-5-incomplete-todo-attribute-ma 2026-04-04 23:08:25 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#125
Delete Branch "feature/issue-83-typo-sligth-of-hand-5-incomplete-todo-attribute-ma"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?