shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add loading states and first-time user onboarding (Closes #88) #130

Merged
shahondin1624 merged 1 commits from feature/issue-88-no-loading-states-or-first-time-user-onboarding into main 2026-04-05 00:47:16 +02:00
Conversation 0 Commits 1 Files Changed 9
+372 -42
shahondin1624 commented 2026-04-05 00:47:08 +02:00
Owner
Copy Link
Copy Source

Summary

  • Add a loading indicator (CircularProgressIndicator) shown while character data is loading from storage
  • Add a welcome/onboarding screen for first-time users with options to create a new character or explore with the example character
  • Use Crossfade animation for smooth transitions between loading, welcome, and main content states

Changes

  • Added LoadStatus.Loading state and made character loading asynchronous in CharacterViewModel
  • Created LoadingScreen composable with progress indicator
  • Created WelcomeScreen composable with create/explore options
  • Updated App.kt to show appropriate screen based on load status using Crossfade
  • Added string resources, test tags, and unit tests

Closes #88

Test plan

  • New LoadingScreenTest verifies loading screen renders
  • New WelcomeScreenTest verifies welcome screen elements and button callbacks
  • Full test suite passes with no regressions (29 pre-existing failures unchanged)
  • Build compiles successfully
## Summary - Add a loading indicator (CircularProgressIndicator) shown while character data is loading from storage - Add a welcome/onboarding screen for first-time users with options to create a new character or explore with the example character - Use Crossfade animation for smooth transitions between loading, welcome, and main content states ## Changes - Added `LoadStatus.Loading` state and made character loading asynchronous in `CharacterViewModel` - Created `LoadingScreen` composable with progress indicator - Created `WelcomeScreen` composable with create/explore options - Updated `App.kt` to show appropriate screen based on load status using `Crossfade` - Added string resources, test tags, and unit tests Closes #88 ## Test plan - [x] New `LoadingScreenTest` verifies loading screen renders - [x] New `WelcomeScreenTest` verifies welcome screen elements and button callbacks - [x] Full test suite passes with no regressions (29 pre-existing failures unchanged) - [x] Build compiles successfully
shahondin1624 added 1 commit 2026-04-05 00:47:08 +02:00
feat: add loading states and first-time user onboarding (Closes #88) 786fa5c4ed 
- Add Loading state to LoadStatus and make character loading asynchronous
- Show CircularProgressIndicator while character data loads from storage
- Show WelcomeScreen for first-time users with options to create a new
  character or explore with the example character
- Use Crossfade animation for smooth transitions between loading, welcome,
  and main content states
- Add test tags, string resources, and tests for new components

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shahondin1624 merged commit a3fe0020ec into main 2026-04-05 00:47:16 +02:00
shahondin1624 deleted branch feature/issue-88-no-loading-states-or-first-time-user-onboarding 2026-04-05 00:47:16 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#130
Delete Branch "feature/issue-88-no-loading-states-or-first-time-user-onboarding"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?