feat: add pool modifier controls and configurable success threshold for dice rolls (Closes #90) #132

2026-04-05T01:41:44+02:00

shahondin1624 commented

2026-04-05 01:41:44 +02:00

Summary

Adds +/- pool modifier controls and quick-select situational modifier buttons (Range, Visibility, Cover, Aim, Smartlink) to the dice roll type selector dialog
Adds configurable success threshold field (defaults to 5) allowing custom thresholds for specific tests
Shows modified pool size and custom threshold in roll result dialogs
Records pool modifier and threshold in roll history entries

Closes #90

Test plan

Verify pool modifier +/- buttons adjust the effective pool size
Verify quick-select modifier chips apply their values cumulatively
Verify success threshold defaults to 5 and can be changed
Verify modified pool and threshold are shown in roll result dialogs
Verify roll history entries show modifier and threshold when non-default
Verify all existing dice tests still pass

## Summary - Adds +/- pool modifier controls and quick-select situational modifier buttons (Range, Visibility, Cover, Aim, Smartlink) to the dice roll type selector dialog - Adds configurable success threshold field (defaults to 5) allowing custom thresholds for specific tests - Shows modified pool size and custom threshold in roll result dialogs - Records pool modifier and threshold in roll history entries Closes #90 ## Test plan - [ ] Verify pool modifier +/- buttons adjust the effective pool size - [ ] Verify quick-select modifier chips apply their values cumulatively - [ ] Verify success threshold defaults to 5 and can be changed - [ ] Verify modified pool and threshold are shown in roll result dialogs - [ ] Verify roll history entries show modifier and threshold when non-default - [ ] Verify all existing dice tests still pass

shahondin1624 added 1 commit 2026-04-05 01:41:44 +02:00

feat: add pool modifier controls and configurable success threshold for dice rolls (Closes #90 ) a98a970876

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

shahondin1624 merged commit d1cd669a3a into main

2026-04-05 01:41:50 +02:00

shahondin1624 deleted branch feature/issue-90-dice-rolls-custom-modifier-threshold

2026-04-05 01:41:50 +02:00

shahondin1624 referenced this issue from a commit

2026-04-05 01:41:51 +02:00

feat: add pool modifier controls and configurable success threshold for dice rolls (Closes #90) (#132)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#132