feat: add visible edit affordances to clickable cards (Closes #143) #145

2026-04-06T17:43:25+02:00

shahondin1624 commented

2026-04-06 17:43:25 +02:00

Summary

Add pencil (edit) icons to Attribute cards, Talent cards, and Character Header when they are editable, making the click-to-edit pattern discoverable
Add a hint text on the Resource Panel directing users to the Character Header for editing resource values (Karma, Nuyen, Essence)
Leverages existing hover elevation feedback already present on cards for desktop/web targets

Closes #143

Files Changed

strings.xml — new edit_content_desc and resource_edit_hint string resources
Attribute.kt — pencil icon shown when onEdit is provided
Talent.kt — pencil icon shown when onEdit is provided
CharacterHeader.kt — pencil icon overlay at top-right when onEdit is provided
ResourcePanel.kt — hint text at bottom of panel

Test Plan

Build compiles successfully
All tests pass (same 29 pre-existing failures, no regressions)
Attribute cards show edit icon when editable
Talent cards show edit icon when editable
Character header shows edit icon when editable
Resource panel shows hint text

## Summary - Add pencil (edit) icons to Attribute cards, Talent cards, and Character Header when they are editable, making the click-to-edit pattern discoverable - Add a hint text on the Resource Panel directing users to the Character Header for editing resource values (Karma, Nuyen, Essence) - Leverages existing hover elevation feedback already present on cards for desktop/web targets Closes #143 ## Files Changed - `strings.xml` — new `edit_content_desc` and `resource_edit_hint` string resources - `Attribute.kt` — pencil icon shown when `onEdit` is provided - `Talent.kt` — pencil icon shown when `onEdit` is provided - `CharacterHeader.kt` — pencil icon overlay at top-right when `onEdit` is provided - `ResourcePanel.kt` — hint text at bottom of panel ## Test Plan - [x] Build compiles successfully - [x] All tests pass (same 29 pre-existing failures, no regressions) - [x] Attribute cards show edit icon when editable - [x] Talent cards show edit icon when editable - [x] Character header shows edit icon when editable - [x] Resource panel shows hint text

shahondin1624 added 1 commit 2026-04-06 17:43:25 +02:00

feat: add visible edit affordances to clickable cards (Closes #143 ) a08f9fa46b

Add pencil icons to Attribute cards, Talent cards, and Character Header
when they are editable, so users can discover click-to-edit without
trial and error. Add a hint on the Resource Panel pointing to the
Character Header for editing resource values.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

shahondin1624 merged commit c17adb4936 into main

2026-04-06 17:43:32 +02:00

shahondin1624 deleted branch feature/issue-143-editing-character-not-discoverable-no-visual-affordances

2026-04-06 17:43:32 +02:00

shahondin1624 referenced this issue from a commit

2026-04-06 17:43:33 +02:00

feat: add visible edit affordances to clickable cards (Closes #143) (#145)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#145