shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

[4.2] Fix DiceRoll Success Counting Bug #16

New Issue
Closed
opened 2026-03-13 11:26:11 +01:00 by shahondin1624 · 0 comments
shahondin1624 commented 2026-03-13 11:26:11 +01:00
Owner
Copy Link

User Story

As a developer, I want DiceRoll.roll() to count successes from the new roll, not the stale result list.

Acceptance Criteria

  • Fix Dice.kt — numberOfSuccesses must be computed from newly rolled values
  • Unit test verifying correct success count after .roll()

Notes

Bug in lib/functions/Dice.kt. The numberOfSuccesses is computed from a stale result list rather than the freshly rolled values. Foundation-phase fix.

## User Story **As a** developer, **I want** `DiceRoll.roll()` to count successes from the new roll, not the stale result list. ## Acceptance Criteria - [ ] Fix `Dice.kt` — `numberOfSuccesses` must be computed from newly rolled values - [ ] Unit test verifying correct success count after `.roll()` ## Notes Bug in `lib/functions/Dice.kt`. The `numberOfSuccesses` is computed from a stale result list rather than the freshly rolled values. Foundation-phase fix.
shahondin1624 added this to the Phase 1: Foundation milestone 2026-03-13 11:26:11 +01:00
shahondin1624 added the epic:dice-rollingpriority:must-have labels 2026-03-13 11:28:15 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label epic:dice-rolling priority:must-have
Milestone
No items
No Milestone Phase 1: Foundation
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#16
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?