shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add in-memory dice roll history (Closes #17) #74

Merged
shahondin1624 merged 1 commits from feature/issue-17-dice-roll-history into main 2026-03-13 14:21:44 +01:00
Conversation 0 Commits 1 Files Changed 6 +355 -1
shahondin1624 commented 2026-03-13 14:21:39 +01:00
Owner
Copy Link

Summary

  • Add DiceRollHistory class storing last 20 rolls in reverse chronological order (label, pool size, results, successes, sequence number)
  • Add DiceRollHistoryDialog showing all history entries with roll numbers, pool sizes, hit counts, and individual die results
  • Add History toolbar icon in the top app bar for quick access
  • Wire CharacterSheetPage to record each dice roll via onRecordRoll callback
  • History is in-memory only, not persisted across restarts (as specified)

Test plan

  • 95 tests total, 18 pre-existing failures unchanged
  • 9 DiceRollHistory unit tests: ordering, capacity (max 20), clearing, defensive copy
  • History icon visible in toolbar
  • Dice rolls recorded when rolling from attribute/talent cards
  • Clear button removes all entries

Closes #17

## Summary - Add `DiceRollHistory` class storing last 20 rolls in reverse chronological order (label, pool size, results, successes, sequence number) - Add `DiceRollHistoryDialog` showing all history entries with roll numbers, pool sizes, hit counts, and individual die results - Add History toolbar icon in the top app bar for quick access - Wire CharacterSheetPage to record each dice roll via `onRecordRoll` callback - History is in-memory only, not persisted across restarts (as specified) ## Test plan - [x] 95 tests total, 18 pre-existing failures unchanged - [x] 9 DiceRollHistory unit tests: ordering, capacity (max 20), clearing, defensive copy - [x] History icon visible in toolbar - [x] Dice rolls recorded when rolling from attribute/talent cards - [x] Clear button removes all entries Closes #17
shahondin1624 added 1 commit 2026-03-13 14:21:39 +01:00
feat: add in-memory dice roll history with toolbar access (Closes #17) ed0526ba5b 
DiceRollHistory stores the last 20 rolls in reverse chronological
order (label, pool size, results, successes, sequence number). A
History icon in the top app bar opens a dialog listing all rolls.
CharacterSheetPage records each dice roll via onRecordRoll callback.
Includes 9 unit tests for history ordering, capacity, and clearing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 7a020cbdc5 into main 2026-03-13 14:21:44 +01:00
shahondin1624 deleted branch feature/issue-17-dice-roll-history 2026-03-13 14:21:44 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#74
Delete Branch "feature/issue-17-dice-roll-history"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?