shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Import replaces entire character with no confirmation warning #84

New Issue
Closed
opened 2026-04-04 18:40:26 +02:00 by shahondin1624 · 0 comments
shahondin1624 commented 2026-04-04 18:40:26 +02:00
Owner
Copy Link
Copy Source

Description

Importing a character from JSON completely replaces the current character data with no confirmation dialog. If a user accidentally pastes wrong JSON and clicks Import, their current character is lost.

Files

  • sharedUI/src/commonMain/kotlin/org/shahondin1624/lib/components/settings/ImportCharacterDialog.kt (lines 18-87)

Expected Behavior

  • Show a confirmation dialog: "This will replace your current character. Are you sure?"
  • Only proceed with import after explicit user confirmation

Acceptance Criteria

  • Confirmation dialog appears before import replaces current character
  • User can cancel the import and keep their current character
  • Successful import still works as before after confirmation
## Description Importing a character from JSON completely replaces the current character data with no confirmation dialog. If a user accidentally pastes wrong JSON and clicks Import, their current character is lost. ## Files - `sharedUI/src/commonMain/kotlin/org/shahondin1624/lib/components/settings/ImportCharacterDialog.kt` (lines 18-87) ## Expected Behavior - Show a confirmation dialog: "This will replace your current character. Are you sure?" - Only proceed with import after explicit user confirmation ## Acceptance Criteria - [ ] Confirmation dialog appears before import replaces current character - [ ] User can cancel the import and keep their current character - [ ] Successful import still works as before after confirmation
shahondin1624 added the epic:character-managementtype:usabilitypriority:must-have labels 2026-04-04 18:40:27 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label epic:character-management priority:must-have type:usability
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#84
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?