shahondin1624/Mitgliederverwaltung
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 16 Wiki Activity

fix: throw exception instead of returning plaintext when encryption fails (Closes #165) #178

Merged
shahondin1624 merged 1 commits from feature/issue-165-encryption-no-plaintext-fallback into main 2026-04-10 16:15:31 +02:00
Conversation 0 Commits 1 Files Changed 2
+10 -7
shahondin1624 commented 2026-04-10 16:15:27 +02:00
Owner
Copy Link
Copy Source

Summary

  • EncryptionService::encrypt() now throws RuntimeException when ICrypto::encrypt() fails, instead of silently returning plaintext
  • Prevents sensitive data (IBAN, Kontoinhaber, Allergien) from being stored unencrypted
  • Updated test to verify the new exception behavior

Test plan

  • All existing unit tests pass with updated expectation
  • Encryption failure now throws RuntimeException
  • Error message is user-friendly in German

Closes #165

## Summary - `EncryptionService::encrypt()` now throws `RuntimeException` when `ICrypto::encrypt()` fails, instead of silently returning plaintext - Prevents sensitive data (IBAN, Kontoinhaber, Allergien) from being stored unencrypted - Updated test to verify the new exception behavior ## Test plan - [x] All existing unit tests pass with updated expectation - [x] Encryption failure now throws RuntimeException - [x] Error message is user-friendly in German Closes #165
shahondin1624 added 1 commit 2026-04-10 16:15:27 +02:00
fix: throw exception instead of returning plaintext when encryption fails (Closes #165) a2ef1e9006 
EncryptionService.encrypt() now throws RuntimeException when ICrypto
fails instead of silently returning plaintext. This prevents sensitive
data (IBAN, medical info) from being stored unencrypted in the database.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shahondin1624 merged commit 7d3be60adb into main 2026-04-10 16:15:31 +02:00
shahondin1624 deleted branch feature/issue-165-encryption-no-plaintext-fallback 2026-04-10 16:15:31 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
Backend / PHP work
 bug
Bug report
 database
Database migrations and schema
 documentation
Documentation
 enhancement
Enhancement or improvement
 epic
Epic / feature-group issues
 frontend
Frontend / Vue.js work
 integration
Nextcloud integrations (Calendar, Contacts, Files)
 priority:high
High priority
 priority:low
Low priority
 priority:medium
Medium priority
 security
Security-related work
 testing
Tests and test infrastructure
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/Mitgliederverwaltung#178
Delete Branch "feature/issue-165-encryption-no-plaintext-fallback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?