shahondin1624/Mitgliederverwaltung
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 16 Wiki Activity

Fix countArchived() loading all members into memory (Closes #201) #201

Merged
shahondin1624 merged 1 commits from fix/n-plus-one-queries-member-list into main 2026-04-29 19:17:36 +02:00
Conversation 0 Commits 1 Files Changed 5
+50 -9
shahondin1624 commented 2026-04-29 19:16:39 +02:00
Owner
Copy Link
Copy Source

Replace in-memory filtering with a SQL COUNT(*) query in the mapper, matching the pattern of the existing countAll() method.

Changes

  • Added MemberMapper::countArchived() using SELECT COUNT(*) WHERE deleted_at IS NOT NULL
  • Updated MemberService::countArchived() to delegate to the new mapper method
  • Updated existing unit test and added new tests for the mapper method
Replace in-memory filtering with a SQL COUNT(*) query in the mapper, matching the pattern of the existing countAll() method. ## Changes - Added MemberMapper::countArchived() using SELECT COUNT(*) WHERE deleted_at IS NOT NULL - Updated MemberService::countArchived() to delegate to the new mapper method - Updated existing unit test and added new tests for the mapper method
shahondin1624 added the backendbug labels 2026-04-29 19:16:39 +02:00
shahondin1624 added 1 commit 2026-04-29 19:16:39 +02:00
Fix countArchived() loading all members into memory (Closes #201)
Database Portability Tests / Unit Tests (PlatformHelper) (pull_request) Failing after 38s
Details
Database Portability Tests / Integration (mysql) (pull_request) Has been skipped
Details
Database Portability Tests / Integration (postgres) (pull_request) Has been skipped
Details
Database Portability Tests / Integration (sqlite) (pull_request) Has been skipped
Details
Database Portability Tests / Verify no MySQL-specific SQL (pull_request) Successful in 5s
Details
d4e25fe739 
Replace in-memory filtering with a SQL COUNT(*) query in the mapper,
matching the pattern of the existing countAll() method.
shahondin1624 merged commit d28dcd4541 into main 2026-04-29 19:17:36 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
Backend / PHP work
 bug
Bug report
 database
Database migrations and schema
 documentation
Documentation
 enhancement
Enhancement or improvement
 epic
Epic / feature-group issues
 frontend
Frontend / Vue.js work
 integration
Nextcloud integrations (Calendar, Contacts, Files)
 priority:high
High priority
 priority:low
Low priority
 priority:medium
Medium priority
 security
Security-related work
 testing
Tests and test infrastructure
No Label backend bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/Mitgliederverwaltung#201
Delete Branch "fix/n-plus-one-queries-member-list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?