shahondin1624/Mitgliederverwaltung
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 16 Wiki Activity

fix(MemberService): wrap multi-step writes in database transactions #203

Merged
shahondin1624 merged 2 commits from fix/missing-database-transactions into main 2026-04-29 22:11:03 +02:00
Conversation 0 Commits 2 Files Changed 5
+244 -31
shahondin1624 commented 2026-04-29 22:10:24 +02:00
Owner
Copy Link
Copy Source

Add IDBConnection dependency to MemberService and wrap create(), update(), and softDelete() in transactions (beginTransaction/commit/rollback). This ensures atomicity when inserting/updating members alongside sub-entities (addresses, phones, emails) — a failure at any step now rolls back the entire operation instead of leaving orphaned records.

(Closes #203)

Add IDBConnection dependency to MemberService and wrap create(), update(), and softDelete() in transactions (beginTransaction/commit/rollback). This ensures atomicity when inserting/updating members alongside sub-entities (addresses, phones, emails) — a failure at any step now rolls back the entire operation instead of leaving orphaned records. (Closes #203)
shahondin1624 added the backendbugpriority:high labels 2026-04-29 22:10:24 +02:00
shahondin1624 added 2 commits 2026-04-29 22:10:24 +02:00
fix(MemberService): wrap multi-step writes in database transactions e1d24d4d54 
Add IDBConnection dependency to MemberService and wrap create(),
update(), and softDelete() in transactions (beginTransaction/commit/
rollback). This ensures atomicity when inserting/updating members
alongside sub-entities (addresses, phones, emails) — a failure at
any step now rolls back the entire operation instead of leaving
orphaned records.

(Closes #203)
chore: move issue-203 plan to done
Database Portability Tests / Unit Tests (PlatformHelper) (pull_request) Failing after 37s
Details
Database Portability Tests / Integration (mysql) (pull_request) Has been skipped
Details
Database Portability Tests / Integration (postgres) (pull_request) Has been skipped
Details
Database Portability Tests / Integration (sqlite) (pull_request) Has been skipped
Details
Database Portability Tests / Verify no MySQL-specific SQL (pull_request) Successful in 5s
Details
0ffc993d3f
shahondin1624 merged commit c4f5f8e7fb into main 2026-04-29 22:11:03 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
Backend / PHP work
 bug
Bug report
 database
Database migrations and schema
 documentation
Documentation
 enhancement
Enhancement or improvement
 epic
Epic / feature-group issues
 frontend
Frontend / Vue.js work
 integration
Nextcloud integrations (Calendar, Contacts, Files)
 priority:high
High priority
 priority:low
Low priority
 priority:medium
Medium priority
 security
Security-related work
 testing
Tests and test infrastructure
No Label backend bug priority:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/Mitgliederverwaltung#203
Delete Branch "fix/missing-database-transactions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?