shahondin1624/Mitgliederverwaltung
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 16 Wiki Activity

refactor(MemberService): extract generic syncSubEntities() method #204

Merged
shahondin1624 merged 2 commits from fix/duplicate-sync-methods into main 2026-04-30 08:14:04 +02:00
Conversation 0 Commits 2 Files Changed 2
+80 -86
shahondin1624 commented 2026-04-30 08:13:52 +02:00
Owner
Copy Link
Copy Source

Factor out the duplicated sync logic from syncAddresses(), syncPhones(), and syncEmails() into a single generic syncSubEntities() method that accepts callables for fetch/update/create/delete operations. Each specialized sync method is now a thin ~10-line wrapper.

(Closes #204)

Factor out the duplicated sync logic from syncAddresses(), syncPhones(), and syncEmails() into a single generic syncSubEntities() method that accepts callables for fetch/update/create/delete operations. Each specialized sync method is now a thin ~10-line wrapper. (Closes #204)
shahondin1624 added the backendpriority:medium labels 2026-04-30 08:13:52 +02:00
shahondin1624 added 2 commits 2026-04-30 08:13:52 +02:00
refactor(MemberService): extract generic syncSubEntities() method bfb57b4e1e 
Factor out the duplicated sync logic from syncAddresses(), syncPhones(),
and syncEmails() into a single generic syncSubEntities() method that
accepts callables for fetch/update/create/delete operations. Each
specialized sync method is now a thin ~10-line wrapper.

(Closes #204)
chore: move issue-204 plan to done 19adf0ba87
shahondin1624 merged commit a0ad92dd47 into main 2026-04-30 08:14:04 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
Backend / PHP work
 bug
Bug report
 database
Database migrations and schema
 documentation
Documentation
 enhancement
Enhancement or improvement
 epic
Epic / feature-group issues
 frontend
Frontend / Vue.js work
 integration
Nextcloud integrations (Calendar, Contacts, Files)
 priority:high
High priority
 priority:low
Low priority
 priority:medium
Medium priority
 security
Security-related work
 testing
Tests and test infrastructure
No Label backend priority:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/Mitgliederverwaltung#204
Delete Branch "fix/duplicate-sync-methods"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?