shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add confirmation dialog before character import replaces current data (Closes #84) #126

Merged
shahondin1624 merged 1 commits from feature/issue-84-import-replaces-entire-character-with-no-confirma into main 2026-04-04 23:27:44 +02:00
Conversation 0 Commits 1 Files Changed 3
+248 -64
shahondin1624 commented 2026-04-04 23:27:36 +02:00
Owner
Copy Link
Copy Source

Summary

  • Adds a confirmation dialog ("Replace Current Character?") that appears after valid JSON is parsed but before the import replaces the current character
  • Users can cancel the confirmation to return to the import dialog without losing their current character
  • Invalid JSON still shows an error inline without triggering the confirmation step
  • Adds 5 new Compose UI tests covering the confirmation flow

Test plan

  • ImportCharacterDialogTest.clickingImportWithValidJsonShowsConfirmationDialog
  • ImportCharacterDialogTest.cancellingConfirmationReturnsToImportDialog
  • ImportCharacterDialogTest.confirmingImportTriggersOnImportCallback
  • ImportCharacterDialogTest.invalidJsonShowsErrorWithoutConfirmation
  • ImportCharacterDialogTest.dismissButtonDismissesDialog

Closes #84

## Summary - Adds a confirmation dialog ("Replace Current Character?") that appears after valid JSON is parsed but before the import replaces the current character - Users can cancel the confirmation to return to the import dialog without losing their current character - Invalid JSON still shows an error inline without triggering the confirmation step - Adds 5 new Compose UI tests covering the confirmation flow ## Test plan - [x] `ImportCharacterDialogTest.clickingImportWithValidJsonShowsConfirmationDialog` - [x] `ImportCharacterDialogTest.cancellingConfirmationReturnsToImportDialog` - [x] `ImportCharacterDialogTest.confirmingImportTriggersOnImportCallback` - [x] `ImportCharacterDialogTest.invalidJsonShowsErrorWithoutConfirmation` - [x] `ImportCharacterDialogTest.dismissButtonDismissesDialog` Closes #84
shahondin1624 added 1 commit 2026-04-04 23:27:36 +02:00
feat: add confirmation dialog before character import replaces current data (Closes #84) 659ac2d655 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 53a8385d0c into main 2026-04-04 23:27:44 +02:00
shahondin1624 deleted branch feature/issue-84-import-replaces-entire-character-with-no-confirma 2026-04-04 23:27:45 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#126
Delete Branch "feature/issue-84-import-replaces-entire-character-with-no-confirma"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?