shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add in-app dice roll results dialog (Closes #15) #61

Merged
shahondin1624 merged 1 commits from feature/issue-15-dice-roll-display into main 2026-03-13 13:38:34 +01:00
Conversation 0 Commits 1 Files Changed 2 +186 -8
shahondin1624 commented 2026-03-13 13:38:29 +01:00
Owner
Copy Link

Summary

  • Add DiceRollResultDialog composable showing individual die values as colored chips (green for successes 5+, red for 1s, neutral for 2-4)
  • Display success count, dice count, glitch detection (ones > half dice), and critical glitch detection (glitch + 0 successes)
  • Wire dialog into CharacterSheetPage via hoisted state, replacing println callbacks in Attribute and Talent roll buttons
  • Dialog uses FlowRow layout for die chips and dismisses on OK button

Closes #15

## Summary - Add `DiceRollResultDialog` composable showing individual die values as colored chips (green for successes 5+, red for 1s, neutral for 2-4) - Display success count, dice count, glitch detection (ones > half dice), and critical glitch detection (glitch + 0 successes) - Wire dialog into `CharacterSheetPage` via hoisted state, replacing `println` callbacks in Attribute and Talent roll buttons - Dialog uses FlowRow layout for die chips and dismisses on OK button Closes #15
shahondin1624 added 1 commit 2026-03-13 13:38:29 +01:00
feat: add in-app dice roll results dialog (Closes #15) a8582ca89c 
Replace println callbacks with a visual dialog showing individual die
values as colored chips (green=success 5+, red=1s), success count,
and glitch/critical glitch detection. Dialog is triggered from both
Attribute and Talent roll buttons via hoisted state in CharacterSheetPage.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 9d530ed398 into main 2026-03-13 13:38:34 +01:00
shahondin1624 deleted branch feature/issue-15-dice-roll-display 2026-03-13 13:38:34 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#61
Delete Branch "feature/issue-15-dice-roll-display"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?