shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: validate attribute values against Shadowrun 5e racial maximums (Closes #86) #128

Merged
shahondin1624 merged 1 commits from feature/issue-86-no-attribute-value-validation-against-shadowrun into main 2026-04-04 23:49:10 +02:00
Conversation 0 Commits 1 Files Changed 5
+222 -6
shahondin1624 commented 2026-04-04 23:49:04 +02:00
Owner
Copy Link
Copy Source

Summary

  • Add MetatypeAttributeLimits object encoding per-metatype attribute maximums (Human/Elf/Dwarf/Ork/Troll) per Shadowrun 5e rules
  • Wire racial max into AttributeEditDialog via CharacterSheetPage so attributes are validated against metatype-appropriate limits
  • Add augmented mode toggle in the edit dialog allowing values up to racial max + 4, with a visual indicator when exceeding racial max
  • Edge attribute maximums are defined per metatype (7 for Humans) and ready for when Edge editing UI is added
  • Add comprehensive unit tests for MetatypeAttributeLimits

Closes #86

Test plan

  • MetatypeAttributeLimitsTest passes (10 tests covering all metatypes, edge, augmented)
  • Existing EditDialogValidationTest attribute tests still pass
  • Build compiles successfully
## Summary - Add `MetatypeAttributeLimits` object encoding per-metatype attribute maximums (Human/Elf/Dwarf/Ork/Troll) per Shadowrun 5e rules - Wire racial max into `AttributeEditDialog` via `CharacterSheetPage` so attributes are validated against metatype-appropriate limits - Add augmented mode toggle in the edit dialog allowing values up to racial max + 4, with a visual indicator when exceeding racial max - Edge attribute maximums are defined per metatype (7 for Humans) and ready for when Edge editing UI is added - Add comprehensive unit tests for `MetatypeAttributeLimits` Closes #86 ## Test plan - [x] `MetatypeAttributeLimitsTest` passes (10 tests covering all metatypes, edge, augmented) - [x] Existing `EditDialogValidationTest` attribute tests still pass - [x] Build compiles successfully
shahondin1624 added 1 commit 2026-04-04 23:49:04 +02:00
feat: validate attribute values against Shadowrun 5e racial maximums (Closes #86) d4ecc85717 
Add MetatypeAttributeLimits with per-metatype attribute maximums per SR5e rules.
Wire racial max into AttributeEditDialog via CharacterSheetPage. Add augmented
mode toggle allowing values up to racial max + 4 with visual indicator.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 32ec4d58ad into main 2026-04-04 23:49:10 +02:00
shahondin1624 deleted branch feature/issue-86-no-attribute-value-validation-against-shadowrun 2026-04-04 23:49:10 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#128
Delete Branch "feature/issue-86-no-attribute-value-validation-against-shadowrun"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?