shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add qualities system with positive/negative traits and karma tracking (Closes #95) #137

Merged
shahondin1624 merged 1 commits from feature/issue-95-qualities-system-positive-negative-with-build-point into main 2026-04-05 03:48:19 +02:00
Conversation 0 Commits 1 Files Changed 11
+1064 -3
shahondin1624 commented 2026-04-05 03:48:13 +02:00
Owner
Copy Link
Copy Source

Summary

  • Adds a Qualities system for Shadowrun 5e characters with positive (karma cost) and negative (karma refund) quality types
  • Includes 37 predefined SR5e qualities (20 positive, 17 negative) with accurate karma costs from the core rulebook
  • Provides full UI panel with add/edit/remove functionality, predefined quality quick-select, custom quality support, and karma cost tracking
  • Schema migration v0.5 -> v0.6 to support existing character data

Closes #95

Test plan

  • Build compiles successfully
  • Existing test suite passes (same baseline as before: 302 tests, 29 pre-existing failures)
  • Migration chain test updated and passing
  • Manual verification: add/remove positive and negative qualities
  • Manual verification: karma cost summary displays correctly
  • Manual verification: predefined quality selection works
  • Manual verification: custom quality creation works
## Summary - Adds a Qualities system for Shadowrun 5e characters with positive (karma cost) and negative (karma refund) quality types - Includes 37 predefined SR5e qualities (20 positive, 17 negative) with accurate karma costs from the core rulebook - Provides full UI panel with add/edit/remove functionality, predefined quality quick-select, custom quality support, and karma cost tracking - Schema migration v0.5 -> v0.6 to support existing character data Closes #95 ## Test plan - [x] Build compiles successfully - [x] Existing test suite passes (same baseline as before: 302 tests, 29 pre-existing failures) - [x] Migration chain test updated and passing - [ ] Manual verification: add/remove positive and negative qualities - [ ] Manual verification: karma cost summary displays correctly - [ ] Manual verification: predefined quality selection works - [ ] Manual verification: custom quality creation works
shahondin1624 added 1 commit 2026-04-05 03:48:13 +02:00
feat: add qualities system with positive/negative traits and karma tracking (Closes #95) 7b7bbeb4e6 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shahondin1624 merged commit a96f5041ea into main 2026-04-05 03:48:19 +02:00
shahondin1624 deleted branch feature/issue-95-qualities-system-positive-negative-with-build-point 2026-04-05 03:48:19 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-creation
Epic: Character creation & build points
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:combat
Epic: Combat & Initiative
 epic:cyberware
Epic: Cyberware/Bioware system
 epic:dice-rolling
Epic: Dice rolling UX
 epic:gear
Epic: Gear, Equipment & Vehicles
 epic:magic
Epic: Spells & Adept Powers
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
 type:architecture
Architecture/infrastructure concern
 type:bug
Bug or code defect
 type:feature
New feature request
 type:usability
UX/usability improvement
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#137
Delete Branch "feature/issue-95-qualities-system-positive-negative-with-build-point"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?