shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add responsive spacing and padding system (Closes #3) #42

Merged
shahondin1624 merged 1 commits from feature/issue-3-responsive-spacing-and-padding-system into main 2026-03-13 12:57:45 +01:00
Conversation 0 Commits 1 Files Changed 4 +110 -5
shahondin1624 commented 2026-03-13 12:57:39 +01:00
Owner
Copy Link

Summary

  • Add UiConstants.Spacing with small(), medium(), and large() functions that scale per WindowSizeClass
  • Replace hardcoded 16.dp in App.kt content padding with Spacing.large()
  • Replace hardcoded 16.dp/8.dp in AttributesPage.kt with Spacing.medium()/Spacing.small()
  • Ranges: Compact 8-12dp, Medium 12-16dp, Expanded 16-24dp

Closes #3

Test plan

  • SpacingTest: 4 tests verifying spacing values and scaling per WindowSizeClass
  • JS compilation verified
  • All 15 new+existing tests pass (only pre-existing ComposeTest failure)
## Summary - Add `UiConstants.Spacing` with `small()`, `medium()`, and `large()` functions that scale per `WindowSizeClass` - Replace hardcoded `16.dp` in `App.kt` content padding with `Spacing.large()` - Replace hardcoded `16.dp`/`8.dp` in `AttributesPage.kt` with `Spacing.medium()`/`Spacing.small()` - Ranges: Compact 8-12dp, Medium 12-16dp, Expanded 16-24dp Closes #3 ## Test plan - [x] SpacingTest: 4 tests verifying spacing values and scaling per WindowSizeClass - [x] JS compilation verified - [x] All 15 new+existing tests pass (only pre-existing ComposeTest failure)
shahondin1624 added 1 commit 2026-03-13 12:57:39 +01:00
feat: add responsive spacing and padding system (Closes #3) f9ea2936d9 
Add WindowSizeClass-aware spacing tokens (small/medium/large) to
UiConstants and replace all hardcoded dp values in App.kt and
AttributesPage.kt. Compact uses 8-12dp, Medium 12-16dp, Expanded 16-24dp.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit c4fea755d0 into main 2026-03-13 12:57:45 +01:00
shahondin1624 deleted branch feature/issue-3-responsive-spacing-and-padding-system 2026-03-13 12:57:45 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#42
Delete Branch "feature/issue-3-responsive-spacing-and-padding-system"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?