shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add centralized TestTags and testTag modifiers (Closes #31) #44

Merged
shahondin1624 merged 1 commits from feature/issue-31-test-tags-on-all-key-components into main 2026-03-13 13:04:01 +01:00
Conversation 0 Commits 1 Files Changed 5 +129 -16
shahondin1624 commented 2026-03-13 13:03:57 +01:00
Owner
Copy Link

Summary

  • Create TestTags.kt object with centralized tag generators: attributeCard(), talentCard(), rollButton(), plus constants for nav items, panels, and toolbar elements
  • Apply testTag modifiers to: Attribute cards, Talent cards, roll buttons (in both Attribute and Talent), navigation drawer items, menu button, and theme toggle
  • Panel tags (character header, resources, derived attributes, damage monitor) defined as constants for future stories

Closes #31

Test plan

  • TestTagsTest: 6 tests verifying tag format, naming, and uniqueness
  • JS compilation verified
  • All 24 new+existing tests pass (only pre-existing ComposeTest failure)
## Summary - Create `TestTags.kt` object with centralized tag generators: `attributeCard()`, `talentCard()`, `rollButton()`, plus constants for nav items, panels, and toolbar elements - Apply `testTag` modifiers to: Attribute cards, Talent cards, roll buttons (in both Attribute and Talent), navigation drawer items, menu button, and theme toggle - Panel tags (character header, resources, derived attributes, damage monitor) defined as constants for future stories Closes #31 ## Test plan - [x] TestTagsTest: 6 tests verifying tag format, naming, and uniqueness - [x] JS compilation verified - [x] All 24 new+existing tests pass (only pre-existing ComposeTest failure)
shahondin1624 added 1 commit 2026-03-13 13:03:57 +01:00
feat: add centralized TestTags and testTag modifiers on all key UI components (Closes #31) 4f41b05100 
Create TestTags.kt with tag generators for attribute cards, talent cards,
roll buttons, nav items, and panel placeholders. Apply testTag modifiers
to Attribute, Talent, and App navigation/toolbar composables.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 6e5a6a3fa1 into main 2026-03-13 13:04:01 +01:00
shahondin1624 deleted branch feature/issue-31-test-tags-on-all-key-components 2026-03-13 13:04:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#44
Delete Branch "feature/issue-31-test-tags-on-all-key-components"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?