shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add editable attribute values (Closes #24) #63

Merged
shahondin1624 merged 1 commits from feature/issue-24-editable-attribute-values into main 2026-03-13 13:47:12 +01:00
Conversation 0 Commits 1 Files Changed 6 +167 -7
shahondin1624 commented 2026-03-13 13:47:07 +01:00
Owner
Copy Link

Summary

  • Add AttributeEditDialog composable with number input, validation (min 1, max 10), and error messages
  • Attribute cards open edit dialog on tap; dice roll button still works independently
  • Changes propagate through CharacterViewModel.updateCharacter() so derived attributes update immediately
  • Add Attributes.withAttribute(type, value) for immutable attribute updates by type
  • Add test tags for attribute edit dialog elements

Closes #24

## Summary - Add `AttributeEditDialog` composable with number input, validation (min 1, max 10), and error messages - Attribute cards open edit dialog on tap; dice roll button still works independently - Changes propagate through `CharacterViewModel.updateCharacter()` so derived attributes update immediately - Add `Attributes.withAttribute(type, value)` for immutable attribute updates by type - Add test tags for attribute edit dialog elements Closes #24
shahondin1624 added 1 commit 2026-03-13 13:47:07 +01:00
feat: add editable attribute values with validation dialog (Closes #24) af33595f43 
Add AttributeEditDialog with number input (min 1, max 10), validation
error messages, and save/cancel buttons. Attribute cards now open the
edit dialog on tap. Changes propagate through CharacterViewModel so
derived attributes update immediately. Add withAttribute() to Attributes
model for immutable attribute updates by type.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 111c86c469 into main 2026-03-13 13:47:12 +01:00
shahondin1624 deleted branch feature/issue-24-editable-attribute-values 2026-03-13 13:47:12 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#63
Delete Branch "feature/issue-24-editable-attribute-values"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?