shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: add card elevation and interaction feedback (Closes #8) #75

Merged
shahondin1624 merged 1 commits from feature/issue-8-card-elevation-feedback into main 2026-03-13 14:24:20 +01:00
Conversation 0 Commits 1 Files Changed 2 +179 -134
shahondin1624 commented 2026-03-13 14:24:15 +01:00
Owner
Copy Link

Summary

  • Add CardDefaults.cardElevation() with default=2dp, pressed=6dp, hovered=4dp to Attribute and Talent cards
  • Switch from Modifier.clickable to Card(onClick=...) for proper Material 3 interaction ripple and pressed elevation animation
  • Extract card content into private AttributeCardContent and TalentCardContent composables to avoid duplication between clickable/non-clickable variants

Test plan

  • Project compiles on all targets
  • 95 tests, 18 pre-existing failures unchanged
  • Cards show elevation shadow at rest (2dp)
  • Cards animate elevation on press (6dp) with ripple feedback
  • Dice button retains its own ripple via IconButton

Closes #8

## Summary - Add `CardDefaults.cardElevation()` with default=2dp, pressed=6dp, hovered=4dp to Attribute and Talent cards - Switch from `Modifier.clickable` to `Card(onClick=...)` for proper Material 3 interaction ripple and pressed elevation animation - Extract card content into private `AttributeCardContent` and `TalentCardContent` composables to avoid duplication between clickable/non-clickable variants ## Test plan - [x] Project compiles on all targets - [x] 95 tests, 18 pre-existing failures unchanged - [x] Cards show elevation shadow at rest (2dp) - [x] Cards animate elevation on press (6dp) with ripple feedback - [x] Dice button retains its own ripple via IconButton Closes #8
shahondin1624 added 1 commit 2026-03-13 14:24:15 +01:00
fix: add card elevation and interaction feedback to Attribute/Talent cards (Closes #8) 50e9b64210 
Use CardDefaults.cardElevation() with default=2dp, pressed=6dp,
hovered=4dp on both Attribute and Talent cards. Switch from
Modifier.clickable to Card(onClick=...) for proper Material 3
interaction ripple and pressed elevation animation. Extract card
content into private composable functions to avoid duplication
between onClick and non-onClick card variants.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 587180dd91 into main 2026-03-13 14:24:20 +01:00
shahondin1624 deleted branch feature/issue-8-card-elevation-feedback 2026-03-13 14:24:20 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#75
Delete Branch "feature/issue-8-card-elevation-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?