shahondin1624/songbook
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: reduce chord-to-lyrics gap from 3mm to 1mm (Closes #23) #26

Merged
shahondin1624 merged 1 commits from feature/issue-23-reduce-chord-lyrics-gap into main 2026-03-17 14:41:05 +01:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
shahondin1624 commented 2026-03-17 14:41:00 +01:00
Owner
Copy Link

Summary

  • Reduced the default chordLineSpacing from 3mm to 1mm in LayoutConfig
  • Both ChordLyricRenderer and MeasurementEngine read this value from config dynamically, so they stay consistent automatically
  • All existing tests pass without modification

Test plan

  • All existing tests pass (./gradlew test)
  • ChordLyricRenderer, MeasurementEngine, and PdfBookRenderer.calculateSectionHeight all read chordLineSpacing from config (no hardcoded values)
  • The new default (1mm / ~2.8pt) provides a tight but readable gap between chords and lyrics

Closes #23

## Summary - Reduced the default `chordLineSpacing` from 3mm to 1mm in `LayoutConfig` - Both `ChordLyricRenderer` and `MeasurementEngine` read this value from config dynamically, so they stay consistent automatically - All existing tests pass without modification ## Test plan - [x] All existing tests pass (`./gradlew test`) - [x] `ChordLyricRenderer`, `MeasurementEngine`, and `PdfBookRenderer.calculateSectionHeight` all read `chordLineSpacing` from config (no hardcoded values) - [x] The new default (1mm / ~2.8pt) provides a tight but readable gap between chords and lyrics Closes #23
shahondin1624 added 1 commit 2026-03-17 14:41:00 +01:00
fix: reduce chord-to-lyrics gap from 3mm to 1mm (Closes #23) 446b8d3922 
The default chordLineSpacing of 3mm created too much vertical distance
between guitar chords and their associated lyrics text. Reducing to 1mm
keeps chords visually connected to the lyrics they belong to.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 077b3c027e into main 2026-03-17 14:41:05 +01:00
shahondin1624 deleted branch feature/issue-23-reduce-chord-lyrics-gap 2026-03-17 14:41:05 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/songbook#26
Delete Branch "feature/issue-23-reduce-chord-lyrics-gap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?