shahondin1624/songbook
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: increase verse spacing default from 4mm to 6mm (Closes #24) #27

Merged
shahondin1624 merged 1 commits from feature/issue-24-fix-verse-spacing into main 2026-03-17 14:52:50 +01:00
Conversation 0 Commits 1 Files Changed 2 +3 -3
shahondin1624 commented 2026-03-17 14:52:43 +01:00
Owner
Copy Link

Summary

  • Increased the default verseSpacing from 4mm to 6mm in LayoutConfig to create clearly visible gaps between consecutive song sections
  • Updated example songbook.yaml to use improved defaults (chord_line_spacing: 1, verse_spacing: 6)
  • The rendering code was already correctly applying verse spacing after each section; the issue was that 4mm was insufficient relative to the inter-line spacing within chord-lyric sections

Test plan

  • All existing tests pass (./gradlew test)
  • Generated PDF visually confirms clear separation between Strophe 1, 2, 3 on song pages
  • Measurement engine and renderer both read verseSpacing from config consistently
  • computeSplitIndex also correctly accounts for verse spacing in split calculations

Closes #24

## Summary - Increased the default `verseSpacing` from 4mm to 6mm in `LayoutConfig` to create clearly visible gaps between consecutive song sections - Updated example `songbook.yaml` to use improved defaults (`chord_line_spacing: 1`, `verse_spacing: 6`) - The rendering code was already correctly applying verse spacing after each section; the issue was that 4mm was insufficient relative to the inter-line spacing within chord-lyric sections ## Test plan - [x] All existing tests pass (`./gradlew test`) - [x] Generated PDF visually confirms clear separation between Strophe 1, 2, 3 on song pages - [x] Measurement engine and renderer both read `verseSpacing` from config consistently - [x] `computeSplitIndex` also correctly accounts for verse spacing in split calculations Closes #24
shahondin1624 added 1 commit 2026-03-17 14:52:43 +01:00
fix: increase verse spacing default from 4mm to 6mm (Closes #24) f183651f51 
The 4mm verse spacing was too subtle relative to the inter-line gaps
within chord-lyric sections, making section boundaries hard to
distinguish. Increasing to 6mm creates a clear visual break between
consecutive song sections (verses, choruses, bridges, repeats).

Also updated the example songbook.yaml to use the improved defaults
(chord_line_spacing: 1, verse_spacing: 6).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit a251fac053 into main 2026-03-17 14:52:50 +01:00
shahondin1624 deleted branch feature/issue-24-fix-verse-spacing 2026-03-17 14:52:50 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/songbook#27
Delete Branch "feature/issue-24-fix-verse-spacing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?