shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add editable talent ratings (Closes #25) #64

Merged
shahondin1624 merged 1 commits from feature/issue-25-editable-talent-ratings into main 2026-03-13 13:50:36 +01:00
Conversation 0 Commits 1 Files Changed 5 +155 -6
shahondin1624 commented 2026-03-13 13:50:31 +01:00
Owner
Copy Link

Summary

  • Add TalentEditDialog with rating input (0-12, 0 = untrained) and validation error messages
  • Talent cards open edit dialog on tap; dice roll button still works independently
  • Dice pool display updates immediately through CharacterViewModel.updateCharacter()
  • Add Talents.withTalentRating() for immutable talent rating updates by name
  • Add test tags for talent edit dialog elements

Closes #25

## Summary - Add `TalentEditDialog` with rating input (0-12, 0 = untrained) and validation error messages - Talent cards open edit dialog on tap; dice roll button still works independently - Dice pool display updates immediately through `CharacterViewModel.updateCharacter()` - Add `Talents.withTalentRating()` for immutable talent rating updates by name - Add test tags for talent edit dialog elements Closes #25
shahondin1624 added 1 commit 2026-03-13 13:50:31 +01:00
feat: add editable talent ratings with validation dialog (Closes #25) d12269cdb5 
Add TalentEditDialog with rating input (0-12, 0 = untrained) and
validation. Talent cards now open edit dialog on tap. Dice pool
display updates immediately through CharacterViewModel. Add
withTalentRating() to Talents model for immutable talent rating updates.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit 227b5c2864 into main 2026-03-13 13:50:36 +01:00
shahondin1624 deleted branch feature/issue-25-editable-talent-ratings 2026-03-13 13:50:36 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#64
Delete Branch "feature/issue-25-editable-talent-ratings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?