shahondin1624/ShadowrunCharSheet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: add Create New Character with confirmation (Closes #30) #73

Merged
shahondin1624 merged 1 commits from feature/issue-30-create-new-character into main 2026-03-13 14:17:45 +01:00
Conversation 0 Commits 1 Files Changed 4 +169
shahondin1624 commented 2026-03-13 14:17:37 +01:00
Owner
Copy Link

Summary

  • Add createNewCharacter() factory in Defaults.kt producing a blank character (attributes at 1, talents at 0, zero karma/nuyen, full essence)
  • Add "New Character" button on the Settings page with confirmation dialog warning about unsaved changes
  • Add 9 unit tests verifying all defaults of the blank character

Test plan

  • 86 tests total, 18 pre-existing failures unchanged
  • New Character button shows confirmation dialog
  • Confirming creates blank character with expected defaults
  • Cancel dismisses without changes

Closes #30

## Summary - Add `createNewCharacter()` factory in Defaults.kt producing a blank character (attributes at 1, talents at 0, zero karma/nuyen, full essence) - Add "New Character" button on the Settings page with confirmation dialog warning about unsaved changes - Add 9 unit tests verifying all defaults of the blank character ## Test plan - [x] 86 tests total, 18 pre-existing failures unchanged - [x] New Character button shows confirmation dialog - [x] Confirming creates blank character with expected defaults - [x] Cancel dismisses without changes Closes #30
shahondin1624 added 1 commit 2026-03-13 14:17:38 +01:00
feat: add Create New Character action with confirmation dialog (Closes #30) bd37709663 
Add createNewCharacter() factory producing a blank ShadowrunCharacter
with all attributes at 1, all talents at rating 0, and default data.
Settings page gains a "New Character" button that shows a confirmation
prompt before replacing the current character. Includes 9 unit tests
verifying the blank character defaults.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 merged commit a6a8d56962 into main 2026-03-13 14:17:45 +01:00
shahondin1624 deleted branch feature/issue-30-create-new-character 2026-03-13 14:17:45 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
epic:cards-rework
Epic: Attribute & Talent cards rework
 epic:character-display
Epic: Character info display
 epic:character-management
Epic: Character management (editing, persistence)
 epic:dice-rolling
Epic: Dice rolling UX
 epic:navigation
Epic: Navigation & page structure
 epic:responsive-layout
Epic: Responsive layout foundation
 epic:testing
Epic: Automated UI testing
 priority:must-have
Priority: Must-have for MVP
 priority:nice-to-have
Priority: Nice-to-have, polish and extras
 priority:should-have
Priority: Should-have, important but not blocking
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/ShadowrunCharSheet#73
Delete Branch "feature/issue-30-create-new-character"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?