shahondin1624/songbook
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: display reference book page numbers in song page footer (Closes #3) #9

Merged
shahondin1624 merged 1 commits from feature/issue-3-display-reference-book-page-numbers-footer into main 2026-03-17 09:33:01 +01:00
Conversation 0 Commits 1 Files Changed 3 +154
shahondin1624 commented 2026-03-17 09:32:24 +01:00
Owner
Copy Link

Summary

  • Renders a two-row footer at the bottom of each song page showing reference book abbreviations as column headers with page numbers below
  • Draws a thin separator line above the footer
  • MeasurementEngine now reserves vertical space for the reference footer when reference books are configured and the song has references
  • Two new layout tests verify footer height reservation behavior

Test plan

  • All existing tests pass
  • New test: references add footer height when reference books configured
  • New test: references do not add height when no reference books configured

Closes #3

## Summary - Renders a two-row footer at the bottom of each song page showing reference book abbreviations as column headers with page numbers below - Draws a thin separator line above the footer - `MeasurementEngine` now reserves vertical space for the reference footer when reference books are configured and the song has references - Two new layout tests verify footer height reservation behavior ## Test plan - [x] All existing tests pass - [x] New test: references add footer height when reference books configured - [x] New test: references do not add height when no reference books configured Closes #3
shahondin1624 added 1 commit 2026-03-17 09:32:25 +01:00
feat: display reference book page numbers in song page footer (Closes #3) 13d1d4525c 
Render a two-row footer at the bottom of each song page showing reference
book abbreviations as column headers with corresponding page numbers below.
A thin separator line is drawn above the footer. MeasurementEngine now
reserves vertical space for the reference footer when reference books are
configured and the song has references.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shahondin1624 force-pushed feature/issue-3-display-reference-book-page-numbers-footer from 13d1d4525c to ba035159f7 2026-03-17 09:32:53 +01:00 Compare
shahondin1624 merged commit ba035159f7 into main 2026-03-17 09:33:01 +01:00
shahondin1624 deleted branch feature/issue-3-display-reference-book-page-numbers-footer 2026-03-17 09:33:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
shahondin1624
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shahondin1624/songbook#9
Delete Branch "feature/issue-3-display-reference-book-page-numbers-footer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?